feat: adds support for OAuth 2 client credentials auth in xapi #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xAPI client currently only supports sending events using the HTTP Basic authentication. This commit expands the authentication method to also include OAuth 2.0 Client Credentials flow.
Agrendalath
reviewed
Sep 4, 2023
| auth_url = models.URLField( | ||
| blank=True, | ||
| null=True, | ||
| help_text=_("URL to use for authentication. Eg., Token URL for OAuth") |
There was a problem hiding this comment.
Should this point to the LMS OAuth2 (e.g., localhost:18000/oauth2/access_token) or directly to the edx-enterprise service? It would be good to clarify this here.
There was a problem hiding this comment.
Ah. I think I have badly explained this PR. The OAuth URL would be from an external LRS service. For example, edCast uses <instance-hostname>/api/lrs/v1/xapi/oauth2/token.
| verbose_name=_('OAuth scope'), | ||
| blank=True, | ||
| null=True, | ||
| help_text=_('The "scope" to pass for OAuth authentication.') |
There was a problem hiding this comment.
What scopes are available here? Could we list them?
There was a problem hiding this comment.
This would be specified by the LRS as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xAPI client currently only supports sending events using the HTTP Basic authentication. This commit expands the authentication method to also include OAuth 2.0 Client Credentials flow.