Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fal-3449 [WIP] #552

Commits on Jul 26, 2023

  1. fix: use student role for zoom in case of global staff. (openedx#32818)

    * fix: use student role for zoom in case of global staff.
    
    * fix: added request cache to avoid duplicate db calls.
    AhtishamShahid authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f4616f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23d6966 View commit details
    Browse the repository at this point in the history
  3. build: npm run build (experimental) (openedx#32823)

    This PR implements much of the static assets rework ADR [1], including:
    
    * `npm run build[-dev]`, and its subcommands,
    * `npm run webpack[-dev]` and
    * `npm run compile-sass[-dev]`.
    
    This is backwards-compatible. `paver update_assets` should not be affected.
    The new command warns that it is "experimental" for a few reasons:
    
    * `npm run build` will fail in the webpack phase unless you first
    run  `xmodule_assets`. This will be changed soon [2].
    
    * We have tested the new build, but not quite so thoroughly that we'd
    recommend it as the production default yet. Once the xmodule_assets
    work lands, we'll share this on the forums so early adopters can try it
    out.
    
    * The commands lack some top-level documentation. Once they stabilize more,
    we'll add a section to the README that explains how and when to use `npm run
    build` and its subcommands and its env vars.
    
    * `npm run watch` is not yet implemented.
    
    References:
    1. https://github.com/openedx/edx-platform/blob/master/docs/decisions/0017-reimplement-asset-processing.rst
    2. openedx#32685
    
    Part of: openedx#31604
    kdmccormick authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3e67719 View commit details
    Browse the repository at this point in the history
  4. fix: learner home serializer key error (openedx#32842)

    * fix: allow missing authOrgId
    
    ---------
    
    Co-authored-by: Leangseu Kim <[email protected]>
    jansenk and leangseu-edx authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4331ee2 View commit details
    Browse the repository at this point in the history
  5. chore: remove warnings from defusedxml package (openedx#32652)

    Co-authored-by: Diego Velásquez <[email protected]>
    diegovr and Diego Velásquez authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    547e5b1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    370ea80 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    51079e5 View commit details
    Browse the repository at this point in the history
  8. build: include built-in XBlock JS directly rather than copying it (op…

    …enedx#32480)
    
    As part of the static asset build, JS modules for most built-in XBlocks were
    unnecessarily copied from the original locations (under xmodule/js and
    common/static/js) to a git-ignored location (under common/static/xmodule), and
    then included into the Webpack builld via
    common/static/xmodule/webpack.xmodule.config.js.
    
    With this commit, we stop copying the JS modules. Instead, we have
    common/static/xmodule/webpack.xmodule.config.js just reference the original
    source under xmodule/js and common/static/js.
    
    This lets us us radically simplify the xmodule/static_content.py build script.
    It also sets the stage for the next change, in which we will check
    webpack.xmodule.config.js into the repository, and delete
    xmodule/static_content.py entirely.
    
    common/static/xmodule/webpack.xmodule.config.js before:
    
        module.exports = {
            "entry": {
                "AboutBlockDisplay": [
                    "./common/static/xmodule/modules/js/000-b82f6c436159f6bc7ca2513e29e82503.js",
                    "./common/static/xmodule/modules/js/001-3ed86006526f75d6c844739193a84c11.js",
                    "./common/static/xmodule/modules/js/002-3918b2d4f383c04fed8227cc9f523d6e.js",
                    "./common/static/xmodule/modules/js/003-b3206f2283964743c4772b9d72c67d64.js",
                    "./common/static/xmodule/modules/js/004-274b8109ca3426c2a6fde9ec2c56e969.js",
                    "./common/static/xmodule/modules/js/005-26caba6f71877f63a7dd4f6796109bf6.js"
                ],
                "AboutBlockEditor": [
                    "./common/static/xmodule/descriptors/js/000-b82f6c436159f6bc7ca2513e29e82503.js",
                    "./common/static/xmodule/descriptors/js/001-19c4723cecaa5a5a46b8566b3544e732.js"
                ],
                // etc
            }
        };
    
    common/static/xmodule/webpack.xmodule.config.js after:
    
        module.exports = {
            "entry": {
                "AboutBlockDisplay": [
                    "./xmodule/js/src/xmodule.js",
                    "./xmodule/js/src/html/display.js",
                    "./xmodule/js/src/javascript_loader.js",
                    "./xmodule/js/src/collapsible.js",
                    "./xmodule/js/src/html/imageModal.js",
                    "./xmodule/js/common_static/js/vendor/draggabilly.js"
                ],
                "AboutBlockEditor": [
                    "./xmodule/js/src/xmodule.js",
                    "./xmodule/js/src/html/edit.js"
                ],
                // etc
            }
        };
    
    Part of: openedx#32481
    kdmccormick authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9d4163d View commit details
    Browse the repository at this point in the history
  9. feat: adds Content Tagging (openedx#32661)

    * refactor: moves is_content_creator
    
    from cms.djangoapps.contentstore.helpers to common.djangoapps.student.auth
    
    * feat: adds content tagging app
    
    Adds models and APIs to support tagging content objects (e.g. XBlocks,
    content libraries) by content authors. Content tags can be thought of as
    "name:value" fields, though underneath they are a bit more complicated.
    
    * adds dependency on openedx-learning<=0.1.0
    * adds tagging app to LMS and CMS
    * adds content tagging models, api, rules, admin, and tests.
    * content taxonomies and tags can be maintained per organization by
      content creators for that organization.
    pomegranited authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8098169 View commit details
    Browse the repository at this point in the history
  10. chore: geoip2: update maxmind geolite country database

    Jenkins authored and edx-transifex-bot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    06e738e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Docker multi-arch images push for linux/amd64, linux/arm64 (openedx#3…

    …2686)
    
    * fix: push docker multi-arch images
    
    ---------
    
    Co-authored-by: Salman Nawaz <[email protected]>
    salman2013 and Salman Nawaz authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e4a1039 View commit details
    Browse the repository at this point in the history
  2. chore: remove warnings for assertNotRegexpMatches method (openedx#32753)

    Co-authored-by: Diego Velásquez <[email protected]>
    diegovr and Diego Velásquez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e92e0e2 View commit details
    Browse the repository at this point in the history
  3. fix: include new assets.txt file in make upgrade (openedx#32860)

    * fix: include new assets.txt file in make upgrade
    * test: update click version to resolve upgrade job failure
    * chore: Updating Python Requirements (openedx#32861)
    UsamaSadiq authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    34f9fc4 View commit details
    Browse the repository at this point in the history
  4. feat: Upgrade Python dependency edx-enterprise

    Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
    jajjibhai008 authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6c1db43 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f7d82e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    06d8a79 View commit details
    Browse the repository at this point in the history
  7. fix: fixed provider not setting in course discussion settings (opened…

    …x#32863)
    
    Co-authored-by: adeel.tajamul <[email protected]>
    muhammadadeeltajamul and adeel.tajamul authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    54467b4 View commit details
    Browse the repository at this point in the history
  8. Merge pull request openedx#32865 from openedx/jajjibhai008/upgrade-ed…

    …x-enterprise-34f9fc4
    
    feat: Upgrade Python dependency edx-enterprise
    jajjibhai008 authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c0e9dc9 View commit details
    Browse the repository at this point in the history
  9. build: commit builtinblocks Webpack config and stub out `xmodule_asse…

    …ts` (openedx#32685)
    
    The Webpack configuration file for built-in XBlock JS used to be
    generated at build time and git-ignored. It lived at
    common/static/xmodule/webpack.xmodule.config.js. It was generated
    because the JS that it referred to was also generated at build-time, and
    the filenames of those JS modules were not static.
    
    Now that its contents have been made entirely static [1], there is no
    reason we need to continue generating this Webpack configuration file.
    So, we check it into edx-platform under the name
    ./webpack.builtinblocks.config.js. We choose to put it in the repo's
    root directory because the paths contained in the config file are
    relative to the repo's root.
    
    This allows us to behead both the xmodule/static_content.py
    (`xmodule_assets`) script andthe  `process_xmodule_assets` paver task, a
    major step in removing the need for Python in the edx-platform asset
    build [2]. It also allows us to delete the `HTMLSnippet` class and all
    associated attributes, which were exclusively used by
    xmodule/static_content.py..
    
    We leave `xmodule_assets` and  `process_xmodule_assets` in as stubs for
    now in order to avoid breaking external code (like Tutor) which calls
    Paver; the entire pavelib/assets.py function will be eventually removed
    soon anyway [3]. Further, to avoid extraneous refactoring, we keep one
    method of `HTMLSnippet` around on a few of its former subclasses:
    `get_html`. This method was originally part of the XModule framework;
    now, it is left over on a few classes as a simple internal helper
    method.
    
    References:
    1. openedx#32480
    2. openedx#31800
    3. openedx#31895
    
    Part of: openedx#32481
    kdmccormick authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    3557799 View commit details
    Browse the repository at this point in the history
  10. build: npm run watch (experimental) (openedx#32866)

    Implements the `npm run watch` section of the assets ADR [1], plus some
    modifications since I decided to switch from pywatchman to watchdog (see
    ADR changes for justification). This will replace `paver watch_assets`
    (edx-platform) and `openedx-assets watch-themes` (Tutor).
    
    Specifically, this PR adds three experimental commands:
    
    * `npm run watch-sass` : Watch for Sass changes with watchdog.
    * `npm run watch-webpack` : Invoke Webpack-watch for JS changes.
    * `npm run watch` : Invoke both `watch-sass` and `watch-webpack` simultaneously.
    
    These commands are only intended to work in development mode. They have
    been tested both on bare-metal edx-platform and through `tutor dev run`
    on on Linux.
    
    Before removing the "experimental" label, we need to:
    
    * Test through Devstack on Linux.
    * Test through Devstack and `tutor dev run` on macOS.
    * Test on bare-metal macOS. Might not work, which is OK, but we should
      document that.
    * Document the commands in edx-platform's README.
    * Confirm that this not only works through `tutor dev run`, but also as
      a suitable replacement in the `watchthemes` service that Tutor runs
      automatically as part of `tutor dev start`. Tweak if necessary.
    
    References:
    
    1. https://github.com/openedx/edx-platform/blob/master/docs/decisions/0017-reimplement-asset-processing.rst
    
    Part of: openedx#31612
    kdmccormick authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    303bf5e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    122ae72 View commit details
    Browse the repository at this point in the history
  12. feat: Add subsection grading policy mismatch validation (openedx#32813)

    Adds validation for the grading assignment and grading policy, showing a
    warning in Studio if there is a mismatch.
    yusuf-musleh authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    884d898 View commit details
    Browse the repository at this point in the history
  13. chore: version bump

    katrinan029 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e3fd89d View commit details
    Browse the repository at this point in the history
  14. Merge pull request openedx#32870 from openedx/knguyen2/ENT-5809-versi…

    …on-bump
    
    chore: version bump
    katrinan029 authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b94b0a8 View commit details
    Browse the repository at this point in the history
  15. feat: taxonomy org api

    rpenido committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b6a9173 View commit details
    Browse the repository at this point in the history
  16. refactor: cleaning code

    rpenido committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b4d216a View commit details
    Browse the repository at this point in the history