Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync opencraft-release/palm.1 with Upstream 20230828-1693180991 #581

Conversation

opencraft-requirements-bot

Syncing opencraft-release/palm.1 with Upstream

Important❗

Please always use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.

Note on Conflicts ⚠️

In cases of conflicts you can go ahead and resolve it here on Github if it is simple enough. However if it is a more complicated conflict please follow the steps below:

  1. Check out sync-open-release/palm.master-20230828-1693180991 locally:
  2. Pull latest changes from opencraft-release/palm.1 into that branch, make sure your [REMOTE] is pointing to opencraft-release/palm.1:
git pull [REMOTE] opencraft-release/palm.1
  1. Resolve the conflicts locally, then commit the result. This will create a new merge commit.
  2. Push the new merge commit to sync-open-release/palm.master-20230828-1693180991 to update this PR
  3. Review the PR again and merge when ready!
    Note: Please use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.

mubbsharanwar and others added 2 commits August 22, 2023 11:43
* refactor: mfe_context response to serialize object keys to camelcase (openedx#31930)

* test: add tests for MFE Context API serializser (openedx#32179)

* fix: empty pipelineUserDetail object

pipelineUserDetail object should be empty when pipeline is not running

---------

Co-authored-by: Shahbaz Shabbir <[email protected]>
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

The failing commitlint test results from squashing the commits from the upstream PR.

@Agrendalath Agrendalath merged commit 81681bb into opencraft-release/palm.1 Aug 29, 2023
40 of 41 checks passed
@Agrendalath Agrendalath deleted the sync-open-release/palm.master-20230828-1693180991 branch August 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants