[BB-7904] fix: youtube race condition when GTM loads #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that might prevent YouTube videos from loading when Google Tag Manager is used.
Both Open edX and GTM implement onYouTubeIframeAPIReady and run already existing implementations of this callback when set up.
The issue arises when GTM overwrites it, as the callback implemented by Open edX expects a
resolve()
attribute that isn't implemented by GTM. This change ensures the original global is used by Open edX so it's never overwritten.Testing
onYouTubeIframeAPIReady
is overwritten by GTM.