Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check masquerade on instructor dashboard tab acess check #601

Conversation

ArturGaspar
Copy link
Member

@ArturGaspar ArturGaspar commented Nov 8, 2023

Backports openedx#33684.

Description

Check also masquerading role to determine if instructor tab is enabled, in order to hide it when a user with acess is masquerading as a student role without a specific different user.

Impacts Staff and Instructor users.

Testing instructions

  1. Create a course with an enrollment track
  2. Preview the course as a staff user
    image
  3. Use the "View this course as:" option to select one of the enrollment tracks
  4. See that the "Instructor" tab is not displayed
    image

Deadline

None

Other information

Private-Ref: https://tasks.opencraft.com/browse/BB-8087

@ArturGaspar ArturGaspar force-pushed the artur/hide-instructor-tab-in-track-masquerade branch from 7c816bb to 7a1c242 Compare November 8, 2023 19:38
@open-craft-grove
Copy link

Sandbox deploy request received. Deployment will start soon.

@open-craft-grove
Copy link

Sandbox deployment started.

@ArturGaspar ArturGaspar force-pushed the artur/hide-instructor-tab-in-track-masquerade branch from 7a1c242 to 251c959 Compare November 8, 2023 20:20
@Agrendalath Agrendalath changed the base branch from opencraft-release/palm.1-echo to opencraft-release/palm.1 November 8, 2023 20:53
@Agrendalath Agrendalath force-pushed the artur/hide-instructor-tab-in-track-masquerade branch from 251c959 to 88e54f9 Compare November 8, 2023 20:54
@Agrendalath Agrendalath force-pushed the artur/hide-instructor-tab-in-track-masquerade branch from 88e54f9 to 5ce151c Compare November 8, 2023 20:55
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the diff matches the upstream PR
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-601-0e7f8a.staging.do.opencraft.hosting

@open-craft-grove
Copy link

Sandbox deployment started.

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-601-0e7f8a.staging.do.opencraft.hosting

@open-craft-grove
Copy link

Sandbox deployment started.

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-601-0e7f8a.staging.do.opencraft.hosting

@Agrendalath Agrendalath merged commit 4df908a into opencraft-release/palm.1 Nov 8, 2023
41 checks passed
@Agrendalath Agrendalath deleted the artur/hide-instructor-tab-in-track-masquerade branch November 8, 2023 22:36
@open-craft-grove
Copy link

Sandbox update request received. Deployment will start soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants