feat: ENTERPRISE_ALGOLIA_SEARCH_API_KEY setting [BB-8083] #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-602-0e7f8a.staging.do.opencraft.hosting |
0x29a
changed the title
Agrendalath
requested changes
Nov 16, 2023
There was a problem hiding this comment.
@0x29a, please see the review comment and open-craft/edx-enterprise#11 (comment). We don't need to add this to the edx-platform.
Comment on lines
+887
to
+890
| ENTERPRISE_ALGOLIA_SEARCH_API_KEY = ENV_TOKENS.get( | ||
| 'ENTERPRISE_ALGOLIA_SEARCH_API_KEY', | ||
| ENTERPRISE_ALGOLIA_SEARCH_API_KEY | ||
| ) |
There was a problem hiding this comment.
Nit: using explicit ENV_TOKENS is a legacy thing - YAML configs are used automatically.
|
Sandbox update request received. Deployment will start soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
ENTERPRISE_ALGOLIA_SEARCH_API_KEYsetting that's intended to be consumed byedx-enterpriseservice. See this PR for more details: open-craft/edx-enterprise#11