Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quince): handle countries not recognized by geoip2 DB #625

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Feb 5, 2024

This backports openedx#34181 to Quince.

The `geoip2` library returns `None` when it only identifies the continent
related to the IP address.
@Agrendalath Agrendalath self-assigned this Feb 5, 2024
Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this
  • I read through the code

@Agrendalath Agrendalath merged commit 43fbbf6 into opencraft-release/quince.1 Feb 7, 2024
42 checks passed
@Agrendalath Agrendalath deleted the agrendalath/handle-unrecognized-countries-quince branch February 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants