fix: store tags in TaggedBlockMixin.tags_v1 field #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we relied on the presence of the xml_attributes field, which is added by the XMLMixin. However, XMLMixin is not part of the default XBLOCK_MIXINS, so custom XBlocks weren't able to copy/paste tags.
pomegranited
commented
Mar 1, 2024
| # Serialize and add tag data if any | ||
| if isinstance(block, TaggedBlockMixin): | ||
| block.add_tags_to_node(olx_node) | ||
|
|
There was a problem hiding this comment.
This step was missing for normal blocks, and so they weren't getting their tags serialized, only HTML blocks were.
|
Thank you for this @pomegranited! I cherry-picked your commit in the other branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on the presence of the xml_attributes field, which is added by the XmlMixin. However, XmlMixin is not part of the default XBLOCK_MIXINS (because not all XBlocks support this), and so custom XBlocks weren't able to copy/paste tags.
This change maintains support for the
tags-v1OLX attribute by adding a field with that name.Testing instructions
pip install edx-ora2==6.1.0