Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DEFAULT_COURSE_INVITATION_ONLY allow for invitation_only new courses by default #652

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: DEFAULT_COURSE_INVITATION_ONLY allow for invitation_only new courses by default #652

merged 1 commit into from
Apr 10, 2024

Conversation

viadanna
Copy link
Member

@viadanna viadanna commented Apr 9, 2024 •
edited
Loading

Description

This pull request adds a DEFAULT_COURSE_INVITATION_ONLY setting to the CMS that, when set to True, makes all courses created in Studio invitation-only by default.

Supporting information

Testing instructions

  1. Deploy this branch to a sandbox or devstack.
  2. Set the DEFAULT_COURSE_INVITATION_ONLY configuration to True in the appropriate configuration file.
  3. Create a new course using Studio.
  4. Verify the course Advanced Settings has invitation_only=True
  5. Set the DEFAULT_COURSE_INVITATION_ONLY configuration to False in the appropriate configuration file.
  6. Repeat steps 3 and 4 to verify invitation_only=False.

Deadline

None

@viadanna viadanna force-pushed the viadanna/default-invitation-only branch from 48c22cd to f7d823f Compare April 9, 2024 20:39
@viadanna viadanna self-assigned this Apr 9, 2024
@viadanna viadanna requested a review from CefBoud April 9, 2024 20:43
CefBoud
CefBoud approved these changes Apr 10, 2024
View reviewed changes
Copy link

@CefBoud CefBoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this, @viadanna ! I left one small question but LGTM ✅

  • I tested this
  • I read through the code
  • Includes documentation (N/A)

lms/envs/common.py Outdated Show resolved Hide resolved
@viadanna viadanna force-pushed the viadanna/default-invitation-only branch from 188417e to cbb73af Compare April 10, 2024 21:37
@viadanna viadanna merged commit 79efe23 into opencraft-release/palm.1 Apr 10, 2024
41 checks passed
@viadanna viadanna deleted the viadanna/default-invitation-only branch April 10, 2024 21:58
@viadanna viadanna restored the viadanna/default-invitation-only branch April 10, 2024 21:59
viadanna added a commit that referenced this pull request Apr 10, 2024
@viadanna
feat: DEFAULT_COURSE_INVITATION_ONLY allow for invitation_only new co…
d0b9d4e 
…urses by default (#652)
@viadanna viadanna mentioned this pull request Apr 10, 2024
Merged
viadanna added a commit that referenced this pull request Apr 11, 2024
@viadanna
feat: DEFAULT_COURSE_INVITATION_ONLY allow for invitation_only new co…
1720dea 
…urses by default (#652) (#653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CefBoud CefBoud CefBoud approved these changes

Assignees

@viadanna viadanna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viadanna @CefBoud