Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collections crud rest api #683

Conversation

ChrisChV
Copy link
Member

@ChrisChV ChrisChV commented Sep 10, 2024

  • Update description as optional: 3c79543
  • Update create collection API to auto-generate key: 8118b77

Copy link
Member

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @ChrisChV!
I think it is missing the handler to update the search index after creating a collection. If you feel this should be done in another task, make sure that you create one for it (I didn't find any).

Copy link
Member

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Thank you for proposing this solution. I'm ok with this change -- since we added Collection.key late in the game, there's no explicit requirement to let users enter their own key, and we're under some time pressure here.

@pomegranited pomegranited merged commit 48a1667 into yusuf-musleh/collections-crud-rest-api Sep 11, 2024
47 checks passed
@pomegranited pomegranited deleted the chris/update-collections-crud-rest-api branch September 11, 2024 01:15
@pomegranited
Copy link
Member

@rpenido

I think it is missing the handler to update the search index after creating a collection. If you feel this should be done in another task, make sure that you create one for it (I didn't find any).

I created this ticket for that: openedx/frontend-app-authoring#1260

Trying to get it done under FAL-3817, but will see.

pomegranited pushed a commit that referenced this pull request Sep 11, 2024
* Update description as optional in ContentLibraryCollectionUpdateSerializer
* Create collection Rest API to auto-generate key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants