refactor: Nit on hooks

open-craft · Apr 18, 2024 · 2e5c81f · 2e5c81f
1 parent 6027d1b
commit 2e5c81f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/content-tags-drawer/ContentTagsDrawer.jsx b/src/content-tags-drawer/ContentTagsDrawer.jsx
@@ -49,6 +49,7 @@ const ContentTagsDrawer = ({ id, onClose }) => {
     toEditMode,
     toastMessage,
     closeToast,
+    setCollapsibleToInitalState,
   } = context;
 
   let onCloseDrawer = onClose;
@@ -81,6 +82,11 @@ const ContentTagsDrawer = ({ id, onClose }) => {
     }
   }, [commitGlobalStagedTagsStatus]);
 
+  // First call of the initial collapsible states
+  React.useEffect(() => {
+    setCollapsibleToInitalState();
+  }, [isTaxonomyListLoaded, isContentTaxonomyTagsLoaded]);
+
   return (
     <ContentTagsDrawerContext.Provider value={context}>
       <div id="content-tags-drawer" className="mt-1 tags-drawer d-flex flex-column justify-content-between min-vh-100">

diff --git a/src/content-tags-drawer/ContentTagsDrawerHelper.jsx b/src/content-tags-drawer/ContentTagsDrawerHelper.jsx
@@ -41,6 +41,7 @@ import messages from './messages';
  *     toastMessage: string | undefined,
  *     showToastAfterSave: () => void,
  *     closeToast: () => void,
+ *     setCollapsibleToInitalState: () => void,
  * }}
  */
 const useContentTagsDrawerContext = (contentId) => {
@@ -335,11 +336,6 @@ const useContentTagsDrawerContext = (contentId) => {
     updateTags.mutate({ tagsData });
   }, [tagsByTaxonomy]);
 
-  // First call of the initial collapsible states
-  React.useEffect(() => {
-    setCollapsibleToInitalState();
-  }, [isTaxonomyListLoaded, isContentTaxonomyTagsLoaded]);
-
   return {
     stagedContentTags,
     addStagedContentTag,
@@ -367,6 +363,7 @@ const useContentTagsDrawerContext = (contentId) => {
     toastMessage,
     showToastAfterSave,
     closeToast,
+    setCollapsibleToInitalState,
   };
 };
 

diff --git a/src/content-tags-drawer/common/context.js b/src/content-tags-drawer/common/context.js
@@ -32,4 +32,5 @@ export const ContentTagsDrawerContext = React.createContext({
   toastMessage: /** @type{string|undefined} */ (undefined),
   showToastAfterSave: /** @type{() => void} */ (() => {}),
   closeToast: /** @type{() => void} */ (() => {}),
+  setCollapsibleToInitalState: /** @type{() => void} */ (() => {}),
 });