Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refined ux update a taxonomy by downloading and uploading (TEMP) #19

Conversation

rpenido
Copy link
Member

@rpenido rpenido commented Dec 6, 2023

Description

This PR improves the import tags functionality for existing taxonomies implemented at openedx#675.

Supporting Information

Testing instructions

Re-import tags to an existing taxonomy

  1. Have an import taxonomy template ready to be imported. You could get one from below:
  2. Go to the taxonomy list page (http://localhost:2001/taxonomies)
  3. Click on the Re-import menu from an existing taxonomy card
  4. You will be prompted with the first page, where you can export the current taxonomy in CVS or JSON format. Check if both buttons export the taxonomy in the desired format:
    image
  5. Click on Next
  6. Will you have to select a CSV or JSON format file to import. You could do this clicking on the component or using drag and drop. Only .csv and .json files should be accepted.
    image
  7. Click on Import to go to the next step.
  8. This page will show the preview actions for this import. Check it and click on Continue. If the file shows no differences, the Continue button will be disabled.
    image
  9. A new confirmation windows will be show. Clicking on Yes, import file should import the tags, replacing the old ones.
    image
  10. The Tag List should be automatically updated.

Private-ref:

@rpenido rpenido force-pushed the rpenido/fal-3539-refined-ux-update-a-taxonomy-by-downloading-and-uploading branch from 2a56eab to 1f52c40 Compare December 7, 2023 00:06
@rpenido rpenido force-pushed the rpenido/fal-3539-refined-ux-update-a-taxonomy-by-downloading-and-uploading branch from 1f52c40 to 4c22a0a Compare December 7, 2023 11:35
@rpenido rpenido force-pushed the rpenido/fal-3539-refined-ux-update-a-taxonomy-by-downloading-and-uploading branch from c6cf04d to 1119041 Compare December 8, 2023 11:45
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (rpenido/fal-3532-import-taxonomy@fdc74c7). Click here to learn what that means.

❗ Current head 72d82d6 differs from pull request most recent head 67e0f7b. Consider uploading reports for the commit 67e0f7b to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             rpenido/fal-3532-import-taxonomy      #19   +/-   ##
===================================================================
  Coverage                                    ?   89.76%           
===================================================================
  Files                                       ?      500           
  Lines                                       ?     8219           
  Branches                                    ?     1725           
===================================================================
  Hits                                        ?     7378           
  Misses                                      ?      813           
  Partials                                    ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido rpenido force-pushed the rpenido/fal-3539-refined-ux-update-a-taxonomy-by-downloading-and-uploading branch from 8d2c437 to b63147a Compare December 8, 2023 14:46
@rpenido rpenido force-pushed the rpenido/fal-3539-refined-ux-update-a-taxonomy-by-downloading-and-uploading branch from 32af5db to 244b83b Compare December 9, 2023 03:11
@ChrisChV
Copy link
Member

ChrisChV commented Dec 19, 2023

Should I handle it or create a new task for this?

@rpenido I think we need to do it now to get it operational for the sandbox. I can fix it if you want, I have time for it

@rpenido
Copy link
Member Author

rpenido commented Dec 19, 2023

I can fix it if you want, I have time for it

I would appreciate that @ChrisChV !

If this is blocking for testing here, the current code will work reimporting any taxonomy created via Import.

@ChrisChV
Copy link
Member

I can fix it if you want, I have time for it

I would appreciate that @ChrisChV !

If this is blocking for testing here, the current code will work reimporting any taxonomy created via Import.

@rpenido I fixed this bug on this PR: openedx/openedx-learning#135
I need to add tests, but you can review it and test it with your PR

@rpenido
Copy link
Member Author

rpenido commented Dec 21, 2023

@rpenido I fixed this bug on this PR: openedx/openedx-learning#135 I need to add tests, but you can review it and test it with your PR

I will check it tomorrow. Thank you @ChrisChV !

rpenido and others added 2 commits December 21, 2023 10:06
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
…v1.177.9 (openedx#762)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Member

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido 👍

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

yusuf-musleh and others added 8 commits January 4, 2024 17:50
This implements filtering taxonomies on the taxonomy list page by selecting organization name, all taxonomies, or unassigned taxonomies.
This change adds a new button in the Taxonomy List to allow users to create new taxonomies by importing a CSV/JSON file.
Add support for fetching content data for Library V2 components in content tags drawer.
@rpenido
Copy link
Member Author

rpenido commented Jan 8, 2024

Closed in favor of openedx#732

@rpenido rpenido closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants