-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refined ux update a taxonomy by downloading and uploading (TEMP) #19
Conversation
2a56eab
to
1f52c40
Compare
1f52c40
to
4c22a0a
Compare
c6cf04d
to
1119041
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rpenido/fal-3532-import-taxonomy #19 +/- ##
===================================================================
Coverage ? 89.76%
===================================================================
Files ? 500
Lines ? 8219
Branches ? 1725
===================================================================
Hits ? 7378
Misses ? 813
Partials ? 28 ☔ View full report in Codecov by Sentry. |
8d2c437
to
b63147a
Compare
Co-authored-by: Braden MacDonald <[email protected]>
32af5db
to
244b83b
Compare
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
@rpenido I think we need to do it now to get it operational for the sandbox. I can fix it if you want, I have time for it |
I would appreciate that @ChrisChV ! If this is blocking for testing here, the current code will work reimporting any taxonomy created via Import. |
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
@rpenido I fixed this bug on this PR: openedx/openedx-learning#135 |
I will check it tomorrow. Thank you @ChrisChV ! |
…-refined-ux-update-a-taxonomy-by-downloading-and-uploading
…v1.177.9 (openedx#762) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido 👍
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
- Includes documentation
This implements filtering taxonomies on the taxonomy list page by selecting organization name, all taxonomies, or unassigned taxonomies.
This change adds a new button in the Taxonomy List to allow users to create new taxonomies by importing a CSV/JSON file.
Add support for fetching content data for Library V2 components in content tags drawer.
…omy-by-downloading-and-uploading
Closed in favor of openedx#732 |
Description
This PR improves the import tags functionality for existing taxonomies implemented at openedx#675.
Supporting Information
Testing instructions
Re-import tags to an existing taxonomy
Re-import
menu from an existing taxonomy cardNext
Import
to go to the next step.Continue
. If the file shows no differences, theContinue
button will be disabled.Yes, import file
should import the tags, replacing the old ones.Private-ref: