feat: Add drag-n-drop support to course unit, refactor tests. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## navin/course-outline/status-design #27 +/- ##
=====================================================================
Coverage ? 90.02%
=====================================================================
Files ? 505
Lines ? 8415
Branches ? 1782
=====================================================================
Hits ? 7576
Misses ? 812
Partials ? 27 ☔ View full report in Codecov by Sentry. |
mavidser
force-pushed
the
sid/bb-8423-unit-dnd
branch
from
40e76db
to
d31be65
Compare
navinkarkera
requested changes
Jan 17, 2024
There was a problem hiding this comment.
@mavidser Nice work! Just left few suggestions and a fix for a minor issue that I encountered. Please take a look.
navinkarkera
force-pushed
the
navin/course-outline/status-design
branch
2 times, most recently
from
652f4ad
to
c00e36d
Compare
mavidser
force-pushed
the
sid/bb-8423-unit-dnd
branch
from
675ca89
to
39185d3
Compare
navinkarkera
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
@mavidser The CI is failing due to a lint issue, please check.
👍
- I tested this: (confirmed that drag-n-drop for units is working)
- I read through the code
mavidser
force-pushed
the
sid/bb-8423-unit-dnd
branch
from
39185d3
to
eee98a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions:
npm run test -- "CourseOutline"