Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0036] feat: tags drawer style refinements #32

Conversation

yusuf-musleh
Copy link

@yusuf-musleh yusuf-musleh commented Apr 8, 2024

Description

This PR makes styling updates to the tags drawer and fixes the issue with scrolling.

Screenshot 2024-04-09 at 3 53 30 PM

Supporting Information

Related PR:

Testing Instruction

  1. Start your local devstack with this PR
  2. Make sure you have some sample taxonomy/tags data setup: https://github.com/open-craft/taxonomy-sample-data
  3. Go into a course and click on "Manage tags" option for any unit/block
  4. Confirm the following:
    1. There is no "x" in the top right of the drawer
    2. Styling of headings has changed to match figma
    3. Dropdown arrows moved to the left of taxonomy name
    4. Styling has changed for the count of tags per taxonomy (also matching figma)
    5. The tag count shows as "0" for taxonomies without tags, and is greyed out.
    6. Make sure the drawer content is scrollable

Private-ref: FAL-3645

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/tags-drawer-style-refinements branch from c926b37 to 7762945 Compare April 9, 2024 11:04
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/tags-drawer-style-refinements branch from f088500 to ad15c04 Compare April 9, 2024 13:04
@yusuf-musleh yusuf-musleh changed the title feat: tags drawer style refinements [FC-0036] feat: tags drawer style refinements Apr 9, 2024
@yusuf-musleh yusuf-musleh marked this pull request as ready for review April 9, 2024 13:07
Copy link
Member

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good 👍

  • I tested this: I checked all style changes listened here
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).

@ChrisChV ChrisChV merged commit 120c17a into chris/FAL-3645-refined-tag-drawer Apr 10, 2024
2 of 3 checks passed
@ChrisChV ChrisChV deleted the yusuf-musleh/tags-drawer-style-refinements branch April 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants