forked from openedx/frontend-app-authoring
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redirect to unit page if the hit or its parent is a unit (TEMP) #35
Closed
rpenido
wants to merge
9
commits into
braden/meilisearch-direct
from
rpenido/fal-3709-allow-redirect-to-the-unit-page-from-search-results
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taxonomies are now sorted by tag count for those with applied tags, and by name for the rest.
…nedx#901) * feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) * fix: add message description
* feat: group configurations - index page * feat: [AXIMST-63] Index group configurations page * fix: resolve discussions * fix: resolve second round discussions * feat: group configurations - content group actions * feat: [AXIMST-75, AXIMST-69, AXIMST-81] Content group actions * fix: resolve conversations * feat: group configurations - sidebar * feat: [AXIMST-87] group-configuration page sidebar * refactor: [AXIMST-87] add changes after review * refactor: [AXIMST-87] add changes after review * refactor: [AXIMST-87] add changes ater review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]> * fix: group configurations - the page reloads after the user saves changes * feat: group configurations - experiment groups * feat: [AXIMST-93, 99, 105] Group configuration - Experiment Groups * fix: [AXIMST-518, 537] Group configuration - resolve bugs * fix: review discussions * fix: revert classname case * fix: group configurations - resolve discussions fix: [AXIMST-714] icon is aligned with text (openedx#210) * fix: add hook tests * fix: add thunk tests * fix: add slice tests * chore: group configurations - messages * fix: group configurations - remove delete in edit mode --------- Co-authored-by: Kyr <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]> Co-authored-by: monteri <lansevermore>
* fix: adding files count in toast * fix: toast to use plural function
rpenido
force-pushed
the
rpenido/fal-3709-allow-redirect-to-the-unit-page-from-search-results
branch
4 times, most recently
from
April 23, 2024 21:06
db3bf8a
to
16000bf
Compare
rpenido
changed the title
feat: redirect to unit page if the hit or its parent is a unit
feat: redirect to unit page if the hit or its parent is a unit (TEMP)
Apr 23, 2024
As of openedx#918 , the content search only allows filtering the results by one tag at a time, which is a limitation of Instantsearch. So with this change, usage of Instantsearch + instant-meilisearch has been replaced with direct usage of Meilisearch. Not only does this simplify the code and make our MFE bundle size smaller, but it allows us much more control over how the tags filtering works, so that we can implement searching by multiple tags. Trying to modify Instantsearch to do that was too difficult, given the complexity of its codebase. Related ticket: openedx/modular-learning#201
rpenido
force-pushed
the
rpenido/fal-3709-allow-redirect-to-the-unit-page-from-search-results
branch
from
April 24, 2024 12:39
fc5df69
to
0d38d98
Compare
Closed in favor of openedx#957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp PR for openedx#957