Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove new library button if user does not have create access #61

Conversation

kaustavb12
Copy link
Member

(cherry picked from commit a9a4d93)

Description

Cherry pick of opendex#1216

Other information

Private Ref: BB-9077

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (4584d6a) to head (fa62cc0).
Report is 3 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           asu-moe/redwood-css      #61   +/-   ##
====================================================
  Coverage                92.44%   92.44%           
====================================================
  Files                      708      708           
  Lines                    12541    12542    +1     
  Branches                  2726     2691   -35     
====================================================
+ Hits                     11594    11595    +1     
  Misses                     912      912           
  Partials                    35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@0x29a 0x29a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I didn't test the cherry-picked version of this due to a problem with the sandbox that I don't know how to solve.
  • Though the changes seem fine to me.

@kaustavb12 kaustavb12 merged commit d4f6606 into asu-moe/redwood-css Aug 31, 2024
5 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/hide_new_library_button_if_no_access_redwood branch August 31, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants