Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the grade removing issues in studio. #72

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

farhaanbukhsh
Copy link
Member

Description

Recently we started noticing that the grade page in the studio doesn't have a way to remove grades once you add them.
This is not the default behavior and it happens only when we add custom themes to the platform.

The default behavior is:

grading.mp4

What are we observing:

grading_glitch.mp4

The fix:

grading_fix.mp4

Useful information to include:

  • We should add in the document/Read me how one can make fixes and what is the right place to put what kind of information.

Supporting information

Private-ref: BB-9232
open-craft/frontend-app-learning#27

Testing instructions

The instruction can get a bit complicated so I am trying to simplify it as much as possible.

I am trying to test course-authoring-mfe here since that is the mfe which is related to studio.

If you have tutor configured and running redwood:

  1. Go to studio
  2. Select any course
  3. Go to "Setting" --> "Grading" (You will find it in header)
  4. Try adding grades
  5. Hover over the grades in between and you will see a "Remove" button

This will prove that the functionality is working in the platform. Let's configure runtime themeing and see what happens.

  1. tutor mounts add /frontend-app-course-authoring
  2. tutor images build openedx-dev
  3. Once that is done cd into frontend-app-course-authoring and change the branch to asu-moe/redwood-css since the token support is available in that branch.
  4. We need to edit MFE_CONFIG I have https://github.com/farhaanbukhsh/tutor-contrib-expermental-mfe to test config, clone this and install in the virtual env of tutor.
  5. Enable the plugin 'tutor plugins enable expermental-mfe'
  6. tutor dev restart lms cms
  7. Once this is done and if you open studio you should see broken UI.
  8. Now clone https://github.com/open-craft/edx-simple-theme and change the branch to [artur/design-tokens-update](https://github.com/open-craft/edx-simple-theme/tree/artur/design-tokens-update)
  9. Run npm ci and npm run build inside the repo
  10. cd dist and run python3 -m http.server 9100
  11. Now hard refresh the studio page and it should be working fine now.
  12. Try to add and remove grade as mentioned above and you shouldn't be able to remove the grade.
  13. Change the branch from 'asu-mo/redwood-css' to 'farhaan/fix-grading-scale', hard refresh and you should be able to add and remove grade.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (acbd7fa) to head (2de407a).
Report is 10 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #72      +/-   ##
=======================================================
+ Coverage                92.54%   92.61%   +0.07%     
=======================================================
  Files                      706      706              
  Lines                    12515    12542      +27     
  Branches                  2728     2703      -25     
=======================================================
+ Hits                     11582    11616      +34     
+ Misses                     898      891       -7     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh 👍

  • I tested this: Verified that the "Remove" button shows up and removes the grade when clicked.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation - NA

@farhaanbukhsh farhaanbukhsh merged commit 3b56fab into asu-moe/redwood-css Oct 14, 2024
5 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/fix-grading-scale branch October 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants