Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-9429] fix: course image height on IOS Safari #4

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: course image height on IOS Safari
Course thumbnails on IOS Safari stretch to the full height of the image,
instead of being limited by width and preserving aspect ratio. This
seems to be a IOS Safari specific behavior[1], and can be fixed by
setting height to auto, while width is set to 100%.

This issues is specific to the context of the course card, so we are
fixing it by setting the height in the course card css, instead of
fixing it globally in the Paragon styles, which wouldn't work in all
contexts.

1: https://stackoverflow.com/a/44250830
Cup0fCoffee committed Dec 30, 2024
commit a3c268fc32b05defb1bf9da618eae863b37edd05
1 change: 1 addition & 0 deletions src/containers/CourseCard/CourseCard.scss
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@
}
.pgn__card-image-cap {
border-bottom-left-radius: 0 !important;
height: auto !important;
}
.overflow-visible {
overflow: visible;