Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional xblocks #9

Open
wants to merge 3 commits into
base: opencraft-release/palm.1
Choose a base branch
from

Conversation

DanielVZ96
Copy link
Member

@DanielVZ96 DanielVZ96 commented Feb 29, 2024

Description

This PR implements separating optional progress from normal progress, and also displaying optional chapters and sequences in the outline.

Testing instructions

follow the instructions from this PR: open-craft/edx-platform#638

Private-ref: BB-8586

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.00%. Comparing base (0991083) to head (1d42457).
Report is 3 commits behind head on opencraft-release/palm.1.

Files Patch % Lines
src/course-home/outline-tab/SequenceLink.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           opencraft-release/palm.1       #9      +/-   ##
============================================================
+ Coverage                     86.95%   87.00%   +0.04%     
============================================================
  Files                           253      254       +1     
  Lines                          4370     4400      +30     
  Branches                       1105     1117      +12     
============================================================
+ Hits                           3800     3828      +28     
- Misses                          551      553       +2     
  Partials                         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/courseware/course/sequence/Unit.jsx Outdated Show resolved Hide resolved
src/courseware/course/sequence/Unit.jsx Outdated Show resolved Hide resolved
src/course-home/data/__snapshots__/redux.test.js.snap Outdated Show resolved Hide resolved
Comment on lines 119 to 137
<small className="text-body pl-2 pr-0">
{optional ? intl.formatMessage(messages.optionalCompletion) : ''}
</small>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a Badge. The text here is related to grading, which is a separate mechanism.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added it as small text because I gelt the Badge overloads the webpage a bit. But maybe it's fine:
image

src/course-home/outline-tab/messages.js Outdated Show resolved Hide resolved
src/courseware/course/sequence/messages.js Outdated Show resolved Hide resolved
@Agrendalath Agrendalath marked this pull request as ready for review March 1, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants