-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for django 4.2 #359
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 45.08% 45.08%
=======================================
Files 40 40
Lines 3309 3309
Branches 463 463
=======================================
Hits 1492 1492
Misses 1769 1769
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @irtazaakram!
Can we also have a new release when this PR is merged?
Please see this comment. I explained why we don't need to update the version in such a case. We mistakenly include the tests in the Python package in this repository, but we do not use them anywhere.
Hi @Agrendalath, Thanks for the review. I've added integration test for Django 4.2. Let me know if this is the right approach. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irtazaakram, the approach looks good, but I'd like to understand where these additional changes (mentioned in the review comments) come from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the CI uses Django 3.2 and 4.2.
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
Description
This is related to ongoing effort to update to Django 4.2 in openedx.
edx/upgrades#381
Supporting information
Changes:
problem_builder/tests/unit/test_answer_mixin.py
bit length is required argument for get_random_string in 4.2
pylintrc
Can we also have a new release when this PR is merged?
Thanks,