Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create benitaronika.domain.json #2052

Closed
wants to merge 1 commit into from
Closed

Create benitaronika.domain.json #2052

wants to merge 1 commit into from

Conversation

benitaronika
Copy link

Requirements

  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.
  • There is no NS Records (Enforced as of Sepetember 4th, 2024)

Description

Link to Website

@benitaronika benitaronika requested a review from a team as a code owner February 21, 2025 08:31
@open-domains
Copy link

open-domains bot commented Feb 21, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@open-domains open-domains bot added the CLA Required Contributor has not signed the CLA. label Feb 21, 2025
DEV-DIBSTER
DEV-DIBSTER requested changes Feb 22, 2025
View reviewed changes
domains/benitaronika.domain.json
Comment on lines +11 to +25
"record": {
"A": ["1.1.1.1", "1.0.0.1"],
"AAAA": ["::1", "::2"],
"CNAME": "benitaronika.com",
"MX": ["mx1.benitaronika.com", "mx2.benitaronika.com"],
"TXT": ["benitaronika_verification=1234567890"],
"CAA": [
{ "flags": 0, "tag": "issue", "value": "letsencrypt.org" },
{ "flags": 0, "tag": "issuewild", "value": "sectigo.com" }
],
"SRV": [
{ "priority": 10, "weight": 60, "port": 5060, "target": "sipserver.benitaronika.com" },
{ "priority": 20, "weight": 10, "port": 5061, "target": "sipbackup.benitaronika.com" }
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid as half of these records are example records. The CNAME cannot be mixed with other records.

domains/benitaronika.domain.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name is not properly set.

@DEV-DIBSTER DEV-DIBSTER added Invalid: Records Records provided are incorrect. Invalid: File File provided is mismatched or not properly formatted. labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEV-DIBSTER DEV-DIBSTER DEV-DIBSTER requested changes

Assignees
No one assigned
Labels
CLA Required Contributor has not signed the CLA. Invalid: File File provided is mismatched or not properly formatted. Invalid: Records Records provided are incorrect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benitaronika @DEV-DIBSTER