Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Deck selection causes keyboard popup on mobile #220

Open
1 of 5 tasks
willroberts opened this issue Oct 29, 2022 · 1 comment
Open
1 of 5 tasks

[P0] Deck selection causes keyboard popup on mobile #220

willroberts opened this issue Oct 29, 2022 · 1 comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed

Comments

@willroberts
Copy link
Collaborator

Summary

When opening a Practice game on Mobile, the keyboard pop ups. This results in a viewport resize, which causes the game to prompt the user to reload the page.

If we can tweak the accessibility options to avoid the keyboard popup, we can avoid this.

Impacted services

  • The frontend app
  • The game servers
  • Game builds or automation scripts
  • Tests or Github Actions
  • Infrastructure (Terraform)

Steps to reproduce

  1. Open https://staging.duelyst.org in Chrome on Android or iOS
  2. Add the page to the home screen
  3. Close Chrome, and then open the app from the home screen
  4. Log in and try to play a practice game
  5. When prompted to select a deck and opponent, the keyboard will pop up

Environment information

  • Operating system: Android
  • Browser: Chrome
  • Browser version: Latest
@willroberts willroberts added bug Something isn't working help wanted Extra attention is needed frontend Related to app / game client code labels Oct 29, 2022
@willroberts
Copy link
Collaborator Author

willroberts commented Nov 4, 2022

This appears to be caused by .focus() calls in app/ui/views and app/ui/views2.

For example, this.ui.$searchInput.focus(); is called in views/composite/deck_select.js, which causes the keyboard popup during deck selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant