Minor fix to migration and Dockerfile #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new field was introduced in a4e781e without a migration.
Newer Python is its own reward, and there's some new MySQL tech I'll need in alpine 3.13. I had to remove py-mysqldb as it's no longer available in alpine3.13. That's fine though, as mariadb-connector-c provides the necessary c-level libraries and other Python requirements are provided through pip. mariadb-connector-c also provides the newer caching_sha2_password.so library for authentication to newer MySQL databasese.
In general users will use the separate OpenEats repository which defines the docker-compose file necessary to run an entire install together. This is fine, but some advanced users may want to run the containers separately. Without these changes it isn't clear which ports are exposed and the container does not actually do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few minor improvements as I was getting to know the project and running it via podman/not docker-compose.