Fixing exception if grocerylist is shared #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
love your work ❤️, been using it for the last 6 months, it made organising my diet a lot easier.
I know it was a small hack, but I started to share one of the grocery lists, sharing works surprisingly well, until the other person wants to update.
This merge requests fixes the permission checking, since it seems that
obj.list.grocerysharedis not valid. I am not a pro with django, so I am not sure if I need to add some kind of migration file to complete this requests. Any help would be welcome.I hope I can improve the software with this tiny commit and help stabilizing it. Keep the good work up.
Thanks and cheers