add soft dependencies #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjsha
approved these changes
Aug 1, 2025
cjsha
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
I think this is less ambiguous, but this might just be my personal preference:
Required for OpenEphys.Onix1 v0.6+ and Open Ephys GUI v1.0+.
It's not only required to use those versions of the software. I think this firmware requires those versions of the software. Should this be mentioned?:
Requires OpenEphys.Onix1 v0.6+ or Open Ephys GUI v1.0+.
That's my input, feel free to take it or leave it. I'll approve and you can make the executive decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107