往HostGroup中添加机器的时候如果发现机器名不存在，就直接插入host表 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlricQin
pushed a commit
that referenced
this pull request
Oct 25, 2015
往HostGroup中添加机器的时候如果发现机器名不存在，就直接插入host表
|
我觉得这个有点不妥，易加错，应该先检查是否在host表中，如果不存在在检查是否在graph库中的endpoint表中，如果存在，这时候在插入host表是比较合理的. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 自定义的Endpoint，没有自动插入到host，导致无法加入到指定的主机组用于告警配置。