feat: Update in-process resolver to support flag metadata #305 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
chrfwow
changed the title
aepfli
approved these changes
Jan 20, 2025
src/OpenFeature.Contrib.Providers.Flagd/Resolver/InProcess/JsonEvaluator.cs
Outdated
Show resolved
Hide resolved
src/OpenFeature.Contrib.Providers.Flagd/Resolver/InProcess/JsonEvaluator.cs
Outdated
Show resolved
Hide resolved
src/OpenFeature.Contrib.Providers.Flagd/Resolver/InProcess/JsonEvaluator.cs
Outdated
Show resolved
Hide resolved
src/OpenFeature.Contrib.Providers.Flagd/Resolver/InProcess/JsonEvaluator.cs
Show resolved
Hide resolved
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
…re#305 Signed-off-by: christian.lutnik <[email protected]>
chrfwow
commented
Jan 20, 2025
| return; | ||
| } | ||
|
|
||
| throw new ParseErrorException("Metadata entry for key " + key + " and value " + value + |
There was a problem hiding this comment.
Is this the proper exception type?
There was a problem hiding this comment.
Ya I think it's the best one.
…re#305 Signed-off-by: christian.lutnik <[email protected]>
toddbaert
reviewed
Jan 27, 2025
| } | ||
| else | ||
| { | ||
| foreach (var key in new List<string>(data.Metadata.Keys)) |
There was a problem hiding this comment.
nit: I think it would be more typical to do this functionally with Linq (.Select) but it's a style choice.
toddbaert
approved these changes
Jan 27, 2025
chrfwow
deleted the
Update-in-process-resolver-to-support-flag-metadata-#305
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for metadata to the flagd provider
Related Issues
Fixes #305