feat: add telemetry helper utils #1346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
============================================
+ Coverage 92.80% 93.34% +0.54%
- Complexity 466 478 +12
============================================
Files 43 45 +2
Lines 1125 1157 +32
Branches 90 98 +8
============================================
+ Hits 1044 1080 +36
+ Misses 53 48 -5
- Partials 28 29 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
chrfwow
approved these changes
Feb 27, 2025
chrfwow
requested changes
Mar 7, 2025
| * @return an EvaluationEvent populated with telemetry data | ||
| */ | ||
| public static EvaluationEvent createEvaluationEvent( | ||
| HookContext<?> hookContext, ProviderEvaluation<?> providerEvaluation) { |
beeme1mr
requested changes
Mar 13, 2025
There was a problem hiding this comment.
The OTel folks requested that we make a couple of changes in the OTel semcon. Let's wait to merge this until those issues have been resolved.
https://cloud-native.slack.com/archives/C07AES1JN56/p1741799036596509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
adds a method to core that returns a semantically valid flag evaluation event
Related Issues
Fixes #1327
Similar to GO PR.