action pr feedback

Signed-off-by: Michael Beemer <[email protected]>

libs/shared/flagd-core/src/lib/feature-flag.ts

@@ -34,6 +34,8 @@ type RequiredResolutionDetails<T> = Omit<ResolutionDetails<T>, 'value'> & {
     | {
         value: T;
         variant: string;
+        errorCode?: never;
+        errorMessage?: never;
       }
   );
 

libs/shared/flagd-core/src/lib/flagd-core.spec.ts

@@ -355,6 +355,7 @@ describe('flagd-core error conditions', () => {
           },
           logger,
         );
+        /* eslint-disable  @typescript-eslint/no-explicit-any */
         (featureFlag as any)['_targeting'] = () => {
           throw new Error('something broke');
         };

libs/shared/flagd-core/src/lib/flagd-core.ts

@@ -182,7 +182,10 @@ export class FlagdCore implements Storage {
 
     const resolution = flag.evaluate(evalCtx, logger);
 
-    // Error during evaluation, returning default value
+    /**
+     * A resolution without a value represents an error condition. It contains
+     * information about the error but requires the default value set.
+     */
     if (resolution.value === undefined) {
       return {
         ...resolution,

libs/shared/flagd-core/src/lib/parser.ts

@@ -56,6 +56,7 @@ export function parse(flagConfig: string, strictValidation: boolean, logger: Log
           flagsKey,
           {
             ...flag,
+            // Flag metadata has higher precedence than flag set metadata
             metadata: {
               ...parsedFlagConfig.metadata,
               ...flag.metadata,