Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: improve eval performance, restructure lib, support flag metadata #1120

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat!: improve eval performance, restructure lib, support flag metadata #1120

wants to merge 8 commits into from
+1,013 −612

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Dec 20, 2024 •
edited
Loading

This PR

  • improve evaluation performance by preloading the config into JSON Logic Engine
  • bumped json logic engine version
  • return evaluation details instead of throwing
  • converted all logs to debug
  • add flag metadata

Related Issues

Pre-req for #1115

Notes

It should be released as v1.

Follow-up Tasks

  • Use in the flagd playground app
  • Using the the flagd JS providers

How to test

  • There are Jest unit tests

@beeme1mr beeme1mr changed the title feat!: improve eval performance, restructure lib feat!: improve eval performance, restructure lib, support flag metadata Dec 24, 2024
@beeme1mr beeme1mr force-pushed the improve-flagd-core branch from e12b784 to 630fc1a Compare January 6, 2025 16:22
@github-actions github-actions bot requested a review from toddbaert January 6, 2025 16:23
@beeme1mr beeme1mr force-pushed the improve-flagd-core branch from 630fc1a to add328b Compare January 6, 2025 16:26
@beeme1mr beeme1mr force-pushed the improve-flagd-core branch from add328b to 6cd5578 Compare January 6, 2025 16:30
beeme1mr
beeme1mr commented Jan 6, 2025
View reviewed changes
libs/shared/flagd-core/src/lib/flagd-core.ts Show resolved Hide resolved
libs/shared/flagd-core/src/lib/flagd-core.ts Outdated Show resolved Hide resolved
libs/shared/flagd-core/src/lib/flagd-core.ts Show resolved Hide resolved
libs/shared/flagd-core/src/lib/flagd-core.ts Outdated Show resolved Hide resolved
libs/shared/flagd-core/src/lib/flagd-core.ts Outdated Show resolved Hide resolved
libs/shared/flagd-core/src/lib/storage.ts Outdated Show resolved Hide resolved
@beeme1mr
action pr feedback
d74e72d 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
fix package lock
45ab996 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
fix lint issues
8e3b8f8 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
renamed vars for consistancy
103fb3c 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
regenerate package lock
c147dfc 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
only update the json-logic-engine version in the package lock
5fbc688 
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
beeme1mr commented Jan 6, 2025
View reviewed changes
release-please-config.json
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"versioning": "default"
"versioning": "default",
"release-as": "1.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove this after the release.

@beeme1mr beeme1mr marked this pull request as ready for review January 6, 2025 20:44
@beeme1mr beeme1mr requested a review from a team as a code owner January 6, 2025 20:44
@toddbaert toddbaert mentioned this pull request Jan 6, 2025
Draft
@beeme1mr
action pr feedback
b7f7632 
Signed-off-by: Michael Beemer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

Assignees

@beeme1mr beeme1mr

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beeme1mr @toddbaert