feat!: add evaluation details fo finally hooks #136
Merged
+44
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian.lutnik <[email protected]>
nicklasl
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Looks good! 👍
If we want to be picky this API change is actually a breaking change but I know we chose to not mark it as that in other SDK's due to the fact that the Hooks concept is experimental in the spec(?).
If you want to have release-please treat it as breaking just (add an ! to the title) change the PR title to feat!:.....
|
Yes, I think we should mark this as breaking since this is a pre-1.0 SDK. In stable SDKs, we manually updated the release notes because hooks are still marked as experimental in the spec and we didn't think the changed justified a new major version. |
beeme1mr
changed the title
beeme1mr
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds evaluation deatils to finally hooks
Related Issues
Fixes #133