[#3855] Catch errors when DMN plugin is not working #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3912 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 714 714
Lines 22354 22354
Branches 2563 2563
=======================================
Hits 21539 21539
Misses 565 565
Partials 250 250 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Feb 20, 2024
SilviaAmAm
force-pushed
the
feature/3855-error-in-admin-no-camunda
branch
from
b19d300
to
212a06b
Compare
|
|
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.js
Outdated
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/3855-error-in-admin-no-camunda
branch
from
212a06b
to
5afccf7
Compare
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.js
Outdated
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/3855-error-in-admin-no-camunda
branch
from
5afccf7
to
6215a3c
Compare
sergei-maertens
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3855
Maybe the plugin ID field should be kept out of the boundary so that the user can select a different plugin in case of errors. Or they can just create a new action and delete the one with errors?