Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3878] Update celery and related dependencies #4259

Merged
merged 3 commits into from
May 4, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented May 3, 2024

Closes #3878

Changes

[Describe the changes here]

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (45fc43d) to head (302aaff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
- Coverage   96.15%   96.13%   -0.03%     
==========================================
  Files         733      733              
  Lines       23532    23532              
  Branches     2760     2760              
==========================================
- Hits        22628    22623       -5     
- Misses        639      642       +3     
- Partials      265      267       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Viicos added 2 commits May 3, 2024 15:19
It now uses a `transaction.on_commit` call, so we need
to execute them so that our `post_save` signal emitting
the logs is triggered.

Note that the `STATUS_QUEUED` will probably be removed in the future,
so this test will need to be updated accordingly when we update.
@sergei-maertens sergei-maertens merged commit 7d49755 into master May 4, 2024
26 of 27 checks passed
@sergei-maertens sergei-maertens deleted the chore/3878-celery branch May 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies after Django 4.2 upgrade
2 participants