Feature/4798 custom confirmation modal

[robinmolen]

Closes #4798

Changes

Replacing all window.confirm(...) confirmations with a new custom React hook (useConfirm). This new hook is using our Modal component to display the confirmation message. These changes happend to keep the application UI uniform.

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (51f9713) to head (022d950).
Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4814   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         748      748           
  Lines       25448    25448           
  Branches     3369     3369           
=======================================
  Hits        24576    24576           
  Misses        608      608           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

@robinmolen can you fix the merge conflicts? Also not sure if the failing tests are related to the code changes?

[robinmolen]

There is a new window.confirm added in a recent commit, in the /form_design/form-creation-form.js. I'll replace that one now with the new useConfirm

[robinmolen]

I've replaced the .../form_design/form-creation-form.js window.confirm with the useConfirm. With that, all window.confirm's have been replaced :)

[sergei-maertens]

Holding of a little longer because of the SDK context/decorator for storybook I mentioned on Slack. I think it would clean up the new/updated interaction tests, and I'm curious if that formik onChange stuff is still necessary, since what it currently does is stop tracking the isTouched state and once we refactor to not roll our validation errors/mechanics 100% on our own, that will definitely cause some problems then :)

[sergei-maertens]

bellissimo