ZGW UX improvements: select document type #4817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4817 +/- ##
=======================================
Coverage 96.57% 96.58%
=======================================
Files 748 748
Lines 25448 25501 +53
Branches 3369 3380 +11
=======================================
+ Hits 24576 24629 +53
Misses 608 608
Partials 264 264 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 12, 2024
sergei-maertens
force-pushed
the
feature/4606-zgw-ux-improvements
branch
5 times, most recently
from
d340a4a
to
46e83b5
Compare
sergei-maertens
force-pushed
the
feature/4606-zgw-ux-improvements
branch
from
46e83b5
to
0671396
Compare
Once a case type is selected, the available document type options are fetched from the backend and we only store the 'description' field value in the configuration options.
Added the serializer option to specify a document type via its description, rather than having to provide a fully qualified URL.
The serializer that produces the available document types is now properly in English, to be consistent with the rest of the serializers. This requires an update to the formio-builder too.
Replaced endpoints with their English variant for consistency.
Tests broke due to changes in behaviour, but the assertions were not updated accordingly yet.
The specified document type is now dynamically resolved within the case type of the created case, using the submissions completion time to determine the correct version to use. The legacy configuration options now emit deprecation warnings, but will still be supported for the foreseeable future.
sergei-maertens
force-pushed
the
feature/4606-zgw-ux-improvements
branch
from
0671396
to
978d252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4606 (partially
TODO
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene