🗑️ [#3283] Make FormDefinitionSerializer.name read only

[stevenbal]

Related to #3283

Changes

• Make FormDefinitionSerializer.name read only

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[stevenbal]

@sergei-maertens do I understand it correctly that this field is currently no longer used for writing? I was wonder whether the import code needs to add the name in translations if it doesn't exist. Or can we assume that imports have these translations already?

[sergei-maertens]

indeed - when we added translations we forgot that the 'main' field could also still be written to and that results in writes happening with the currently active locale (so if you have the UI in english, it would write to name_en).

Things didn't break so far because the translations are defined after the name field, so those overwrite the name_en and name_nl fields again, but that was not deliberately and works completely by accident.

You can indeed assume the imports have translations already, and if they don't, well, it's one of the things to mention in the 3.0 release notes and a reason why this was postponed until a major version :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (51f9713) to head (cae00db).
Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4829   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         748      748           
  Lines       25448    25448           
  Branches     3369     3369           
=======================================
  Hits        24576    24576           
  Misses        608      608           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.