Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/4823 upload file with leading space #4830

Closed
wants to merge 2 commits into from

Conversation

robinmolen
Copy link
Contributor

Closes #4823

Changes

When uploading a file with a leading space, the website will show a descriptive error message.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen force-pushed the bug/4823-upload-file-with-leading-space branch from 9ececb9 to d50482a Compare November 18, 2024 16:36
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (4b73a1d) to head (d50482a).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/formio/components/vanilla.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
- Coverage   96.57%   96.56%   -0.01%     
==========================================
  Files         747      747              
  Lines       25400    25402       +2     
  Branches     3355     3356       +1     
==========================================
  Hits        24529    24529              
- Misses        608      609       +1     
- Partials      263      264       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@robinmolen robinmolen marked this pull request as draft November 19, 2024 08:15
@robinmolen robinmolen closed this Nov 19, 2024
@robinmolen
Copy link
Contributor Author

Closed this PR in favor of #4833

@robinmolen robinmolen deleted the bug/4823-upload-file-with-leading-space branch November 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upload file with leading white space in the filename
1 participant