-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher Overhaul #104
Merged
Merged
Launcher Overhaul #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Add support for texture packs - [x] Override default Tauri updater dialog - [x] Custom top menu bar - [x] Added support links to github issues (jak-project, launcher) & discord - [x] New progress bar / progress stepper - [x] Highlight active route in sidebar - [ ] Add an error handling screen - [x] Connect update notes properly
For whatever reason, these triggered in dev but not in release builds. However, I already made a global store for managing the versions, so events aren't really needed -- but this may be a problem in the future
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has an absolute ton of changes. It's not 100% ready yet, but I'm opening it early to start crossing off issues. I don't think this will be done/tested in time for this months release. But probably next month's.
The major change here is that the launcher's release will no longer be tightly coupled to the jak-project's release. Which is to say, it will no longer distribute the relevant binaries as a sidecar. This means the launcher will manage your jak-project release(s) and only has advantages from my perspective:
gk/goalc/etc
-- think modsThe only disadvantage is related to testing (ie. ideally you would test the launcher works with the consumed binary from
jak-project
_before_releasing) But this is a non-issue -- we can't do any of this testing without an ISO within the CI.This moves a lot of the typescript code (frontend) into the rust layer (backend). For a few reasons:
Fixed Issues
data
directory around (besides file permission issues) but it no longer exists, so easy fix therejak-project
release notes as part of the normal release processnpm
toyarn
#100decompile
orcompile
#11pc-settings.old.gc
wgpu
in order to get GPU information and this seems to easily allow VK checks as well.Deferred
data/iso_data
which when you are explicitly providing the folder -- is wrong. I also need to check if it validates the folder contentswebm
format #107 - new issue, linux and gstreamer doesn't seem to likewebm
files. Test with mp4