feedback: safer database (fixes #3311) (#3316)

Co-authored-by: dogi <[email protected]>
open-learning-exchange · Mar 27, 2024 · 27a8829 · 27a8829
1 parent 29449b8
commit 27a8829
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdkVersion 21
         targetSdkVersion 34
-        versionCode 1451
-        versionName "0.14.51"
+        versionCode 1452
+        versionName "0.14.52"
         ndkVersion '21.3.6528147'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

diff --git a/app/src/main/java/org/ole/planet/myplanet/ui/feedback/FeedbackFragment.kt b/app/src/main/java/org/ole/planet/myplanet/ui/feedback/FeedbackFragment.kt
@@ -24,7 +24,7 @@ class FeedbackFragment : DialogFragment(), View.OnClickListener {
     private lateinit var fragmentFeedbackBinding: FragmentFeedbackBinding
     private lateinit var mRealm: Realm
     private lateinit var databaseService: DatabaseService
-    private lateinit var model: RealmUserModel
+    private var model: RealmUserModel? = null
     var user: String? = ""
 
     interface OnFeedbackSubmittedListener {
@@ -45,8 +45,10 @@ class FeedbackFragment : DialogFragment(), View.OnClickListener {
         fragmentFeedbackBinding = FragmentFeedbackBinding.inflate(inflater, container, false)
         databaseService = DatabaseService(requireActivity())
         mRealm = databaseService.realmInstance
-        model = UserProfileDbHandler(requireContext()).userModel!!
-        user = model.name
+        if (model != null) {
+            model = UserProfileDbHandler(requireContext()).userModel
+        }
+        user = model?.name
         fragmentFeedbackBinding.btnSubmit.setOnClickListener(this)
         fragmentFeedbackBinding.btnCancel.setOnClickListener(this)
         return fragmentFeedbackBinding.root