courses: better course step display (fixes #2771) (#2782)

Co-authored-by: dogi <[email protected]>
open-learning-exchange · Dec 4, 2023 · 7318f53 · 7318f53
1 parent e7cdac8
commit 7318f53
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdkVersion 21
         targetSdkVersion 34
-        versionCode 1178
-        versionName "0.11.78"
+        versionCode 1179
+        versionName "0.11.79"
         ndkVersion '21.3.6528147'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

diff --git a/app/src/main/java/org/ole/planet/myplanet/ui/course/CourseStepFragment.java b/app/src/main/java/org/ole/planet/myplanet/ui/course/CourseStepFragment.java
@@ -142,7 +142,7 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
         fragmentCourseStepBinding.description.setMovementMethod(LinkMovementMethod.getInstance());
 
         if (!RealmMyCourse.isMyCourse(user.getId(), step.getCourseId(), mRealm)) {
-            fragmentCourseStepBinding.btnTakeTest.setVisibility(View.INVISIBLE);
+            fragmentCourseStepBinding.btnTakeTest.setVisibility(View.GONE);
         }
         setListeners();
 
@@ -164,7 +164,7 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
     }
 
     private void hideTestIfNoQuestion() {
-        fragmentCourseStepBinding.btnTakeTest.setVisibility(View.INVISIBLE);
+        fragmentCourseStepBinding.btnTakeTest.setVisibility(View.GONE);
         if (stepExams != null && stepExams.size() > 0) {
             String first_step_id = stepExams.get(0).getId();
             RealmResults<RealmExamQuestion> questions = mRealm.where(RealmExamQuestion.class).equalTo("examId", first_step_id).findAll();

diff --git a/app/src/main/res/layout/fragment_course_step.xml b/app/src/main/res/layout/fragment_course_step.xml
@@ -13,6 +13,7 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_gravity="right"
+            android:layout_marginEnd="@dimen/_10dp"
             android:gravity="right">
 
             <Button
@@ -58,7 +59,9 @@
             <TextView
                 android:id="@+id/description"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content" />
+                android:layout_height="wrap_content"
+                android:layout_marginStart="@dimen/_10dp"
+                android:layout_marginEnd="@dimen/_10dp" />
         </LinearLayout>
     </LinearLayout>