dashboard: better strings (fixes #3683) #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
which deprecation was this solving? |
|
I apologize I should have renamed the issue. This was for clearing up the warnings. @Okuro3499 |
|
@rlam20 you could add that warning to the issue description |
ewhang5
approved these changes
Jun 27, 2024
Okuro3499
requested changes
Jun 27, 2024
| @@ -80,6 +81,7 @@ class DashboardActivity : DashboardElementActivity(), OnHomeItemClickListener, N | |||
| super.attachBaseContext(LocaleHelper.onAttach(base)) | |||
| } | |||
|
|
|||
| @SuppressLint("SetTextI18n") | |||
There was a problem hiding this comment.
android studio give a suggestion on a better way to handle this instead of suppressing String literal in setText can not be translated. Use Android resources instead
Okuro3499
requested changes
Jul 1, 2024
| activityDashboardBinding.appBarBell.appTitleName.text = "$name's Planet" | ||
| activityDashboardBinding.appBarBell.appTitleName.text = name + getString(R.string.planet) |
There was a problem hiding this comment.
-
this changes how the text appears
current on masterGideon's planet
on this branchGideon planet -
warning is still not resolved Follow this link on how to resolve it solution link
- default and lite don't have the same changes
- we have some conflicts
Okuro3499
approved these changes
Jul 2, 2024
strawberrybread
approved these changes
Jul 2, 2024
dogi
approved these changes
Jul 2, 2024
dogi
changed the title
dogi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3683