Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat: mark shared (fixes #3734) #3735

Merged
merged 4 commits into from
Jul 1, 2024
Merged

chat: mark shared (fixes #3734) #3735

merged 4 commits into from
Jul 1, 2024

Conversation

Okuro3499
Copy link
Collaborator

@Okuro3499 Okuro3499 commented Jun 28, 2024 •
edited
Loading

fixes #3734

Screenshot_20240628_142705

rlam20
rlam20 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@rlam20 rlam20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the check mark won't display until the page is refreshed

ewhang5
ewhang5 requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ewhang5 ewhang5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @rlam20

@Okuro3499
Copy link
Collaborator Author

ok will work on that

@Okuro3499 Okuro3499 requested review from rlam20 and ewhang5 July 1, 2024 10:00
rlam20
rlam20 reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@rlam20 rlam20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A future improvement could be having the option to share again or share to multiple teams/communities.

@dogi dogi merged commit 45a922b into master Jul 1, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 3734-duplicate-shared-chat branch July 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strawberrybread strawberrybread strawberrybread approved these changes

@ewhang5 ewhang5 ewhang5 approved these changes

@rlam20 rlam20 rlam20 approved these changes

@dogi dogi dogi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicate shared chat
5 participants
@Okuro3499 @dogi @rlam20 @ewhang5 @strawberrybread