Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: smoother empty list (fixes #3727) #3743

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

strawberrybread
Copy link
Contributor

fixes #3727

image

@ewhang5
Copy link
Contributor

ewhang5 commented Jul 1, 2024

@strawberrybread I would recommend solving the merge conflicts that are shown below. Should be super quick but would be nice for when merging. Also, can you let me know how exactly to test this? For some reason, my teams page is never empty.

@strawberrybread
Copy link
Contributor Author

@strawberrybread I would recommend solving the merge conflicts that are shown below. Should be super quick but would be nice for when merging. Also, can you let me know how exactly to test this? For some reason, my teams page is never empty.

I tested by using an empty list, val emptyList = emptyList<RealmMyTeam>(), inside of setTeamList() and updatedTeamList().

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reuse showNoData function from BaseRecyclerFragment

@strawberrybread strawberrybread requested a review from Okuro3499 July 2, 2024 15:24
Okuro3499
Okuro3499 previously approved these changes Jul 3, 2024
@Okuro3499 Okuro3499 dismissed their stale review July 3, 2024 10:41

conflicts

@dogi dogi changed the title teams: smoother empty team list (fixes #3727) teams: smoother empty list (fixes #3727) Jul 3, 2024
@dogi dogi merged commit 6a2d508 into master Jul 3, 2024
2 checks passed
@strawberrybread strawberrybread deleted the 3727-better-placeholder-for-empty-teamenterprise-list branch July 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better placeholder for empty team/enterprise list
5 participants