Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: less warnings is more (fixes #3775) #3782

Merged
merged 9 commits into from
Jul 9, 2024
Merged

actions: less warnings is more (fixes #3775) #3782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47a67b7
actions: less warnings is more (fixes #3699) (#3703)
rlam20 Jul 3, 2024
29dbf23
solve rebase
ewhang5 Jul 3, 2024
2f4c7dc
actions: less is more (fixes #3775)
ewhang5 Jul 3, 2024
7155aa1
Update strings.xml
dogi Jul 3, 2024
16b9573
Update VersionUtils.kt
ewhang5 Jul 3, 2024
724ec75
address concerns
ewhang5 Jul 3, 2024
826f993
undo mistake
ewhang5 Jul 3, 2024
5b8764b
Update build.gradle
dogi Jul 9, 2024
a8f78b2
Merge branch 'master' into 3775-version-code-deprecation
dogi Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ android {
applicationId "org.ole.planet.myplanet"
minSdkVersion 21
targetSdkVersion 34
versionCode 1664
versionName "0.16.64"
versionCode 1665
versionName "0.16.65"
ndkVersion '21.3.6528147'
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true
Expand Down
9 changes: 8 additions & 1 deletion app/src/main/java/org/ole/planet/myplanet/utilities/VersionUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@ package org.ole.planet.myplanet.utilities

import android.content.Context
import android.content.pm.PackageManager
import android.os.Build
import android.provider.Settings
import androidx.core.content.pm.PackageInfoCompat.getLongVersionCode

object VersionUtils {
@JvmStatic
fun getVersionCode(context: Context): Int {
try {
val pInfo = context.packageManager.getPackageInfo(context.packageName, 0)
return pInfo.versionCode
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
return getLongVersionCode(pInfo).toInt()
} else {
@Suppress("DEPRECATION")
return pInfo.versionCode
}
} catch (e: PackageManager.NameNotFoundException) {
e.printStackTrace()
}
Expand Down