Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat: smoother refresh (fixes #3784) #3786

Merged
merged 5 commits into from
Jul 8, 2024
Merged

chat: smoother refresh (fixes #3784) #3786

merged 5 commits into from
Jul 8, 2024

Conversation

Okuro3499
Copy link
Collaborator

@Okuro3499 Okuro3499 commented Jul 5, 2024 •
edited
Loading

@Okuro3499 Okuro3499 requested review from rlam20 and ewhang5 July 5, 2024 14:18
rlam20
rlam20 requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@rlam20 rlam20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but when you start with an empty chat list and start a new chat, the list does not refresh:
image

However once you hit the 'new chat' button it will all show up

@Okuro3499
Copy link
Collaborator Author

@rlam20 test for updates

@dogi dogi changed the title chat: smoother refresh on submit (fixes #3784) chat: smoother refresh (fixes #3784) Jul 8, 2024
@dogi dogi merged commit d37137a into master Jul 8, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 3784-new-chat-not-showing branch July 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strawberrybread strawberrybread strawberrybread approved these changes

@ewhang5 ewhang5 ewhang5 approved these changes

@rlam20 rlam20 rlam20 approved these changes

@dogi dogi dogi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new chat not showing
5 participants
@Okuro3499 @dogi @rlam20 @ewhang5 @strawberrybread