Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: easier configuration (fixes #3742) #3965

Closed
wants to merge 17 commits into from

Conversation

ewhang5
Copy link
Contributor

@ewhang5 ewhang5 commented Jul 29, 2024

Additions:

  • Implemented UI of MaterialButtonToggleGroup and MaterialButtons
  • Improved some other UI aspects of

TODO:

  • Remove SYNC button
  • Move functionality so that when any of the MaterialButtons is pressed, the sync is automatically triggered

@ewhang5 ewhang5 added the WIP label Jul 29, 2024
@Okuro3499
Copy link
Collaborator

Remove SYNC button
Move functionality so that when any of the MaterialButtons is pressed, the sync is automatically triggered

@ewhang5 about the implementation of the above, what if a wrong server is selected by mistake
will we have a button to cancel sync?
what will be the implications of this to the couch db?

@ewhang5
Copy link
Contributor Author

ewhang5 commented Jul 30, 2024

Remove SYNC button Move functionality so that when any of the MaterialButtons is pressed, the sync is automatically triggered

@ewhang5 about the implementation of the above, what if a wrong server is selected by mistake will we have a button to cancel sync? what will be the implications of this to the couch db?

@Okuro3499 this was also a slight concern of mine, but dogi wanted the sync to happen automatically. I think if the user tries to sync to a new server, they should still receive the same prompt asking for a confirmation, so hopefully that can work to allow for cancelling a sync. What do you think about this?

@dogi
Copy link
Member

dogi commented Aug 1, 2024

#3982

@dogi dogi closed this Aug 1, 2024
@Okuro3499 Okuro3499 deleted the 3742-easy-settings-config-ewhang5 branch October 7, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants