Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to First Steps and Github Issues Pages to Clarify it is OK to Move On (fixes #2554) #2591

Conversation

johnmdrake1
Copy link
Contributor

Fixes #2554

Description

I have added notes to both the "Github Issues" pages and "First Steps" pages(in the Step 6 Section) to make it clearer that Aspiring VI's can continue working on Issues and Pull requests while waiting on approval for another one. This lets them know that they can continue making progress and move on to the next step if their Pull Request has not yet been merged. Removed the words that said you must have your Step 6 PR merged before moving on. See #2554 for more discussion on this issue.

Anything else I can add to improve these changes, please allow me to know.

Checklist

[x] Check for issue number in pull request title
[x] Are there any unneeded files in the pull request?
[x] Did they make a branch for their patch?
[x] Does the pull request actually fix the issue?
[x] Check the pull request on raw.githack, does it display without any errors?
[x] Is there any merge conflicts?
[x] Make sure that people use their GitHub accounts when making commits through git

Raw.Githack preview link

https://raw.githack.com/johnmdrake1/johnmdrake1.github.io/issues-and-pr-clarification-johnmdrake1/#!pages/vi/vi-first-steps.md

https://raw.githack.com/johnmdrake1/johnmdrake1.github.io/issues-and-pr-clarification-johnmdrake1/#!pages/vi/vi-github-issues.md

@johnmdrake1
Copy link
Contributor Author

@ChiragAwale @perryc85 This is what I have for a fix as we discussed in #2554 , thought you may want to see

@perryc85 perryc85 merged commit cb5d483 into open-learning-exchange:master Jul 24, 2019
Kuljeet1998 pushed a commit to Kuljeet1998/Kuljeet1998.github.io that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When it is OK to Move on during First Steps Needs to be Specified
3 participants