Improved error handling withing the chatapi

open-learning-exchange · Dec 22, 2023 · 13e29fb · 13e29fb
1 parent 5640e00
commit 13e29fb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/chatapi/src/index.ts b/chatapi/src/index.ts
@@ -23,21 +23,25 @@ app.post('/', async (req: any, res: any) => {
   try {
     const { data, save } = req.body;
 
+    if (typeof data !== 'object' || Array.isArray(data) || Object.keys(data).length === 0) {
+      res.status(400).json({ 'error': 'Bad Request', 'message': 'The "data" field must be a non-empty object' });
+    }
+
     if (!save) {
       const response = await chatNoSave(data.content);
       res.status(200).json({
         'status': 'Success',
         'chat': response
       });
-    } else if (save && data && typeof data === 'object') {
+    } else if (save) {
       const response = await chat(data);
       res.status(201).json({
         'status': 'Success',
         'chat': response?.completionText,
         'couchDBResponse': response?.couchSaveResponse
       });
     } else {
-      res.status(400).json({ 'error': 'Bad Request', 'message': 'The "data" field must be a non-empty object' });
+      res.status(400).json({ 'error': 'Bad Request', 'message': 'Error processing "data" object' });
     }
   } catch (error: any) {
     res.status(500).json({ 'error': 'Internal Server Error', 'message': error.message });

diff --git a/chatapi/src/services/chat.service.ts b/chatapi/src/services/chat.service.ts
@@ -18,6 +18,10 @@ export async function chat(data: any): Promise<{
   const { content, ...dbData } = data;
   const messages: ChatMessage[] = [];
 
+  if (!content) {
+    throw new Error('"data.content" is a required non-empty field');
+  }
+
   if (dbData._id) {
     await retrieveChatHistory(dbData, messages);
   } else {