Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: smoother calendar (fixes #6796) #7692

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

sahilvunnam
Copy link
Member

fixes #6796

@Mutugiii I believe that I fixed the calendar toolbar, are you able to check if it works for super small screens as I'm not able to check that on my laptop

@sahilvunnam sahilvunnam linked an issue Oct 31, 2024 that may be closed by this pull request
@sahilvunnam sahilvunnam requested a review from Mutugiii October 31, 2024 13:27
Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the screenshot for your code - I think it first started at 375 pixels
Screenshot 2024-10-31 at 7 45 35 AM

Screenshot 2024-10-31 at 7 45 43 AM

Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting around 505px width. Looks fine except when you open the sidebar, so the original issue persists.

image

image

Interestingly, for me the buttons looks fine even on the narrowest screens, as long the sidebar is closed.

image

@sahilvunnam
Copy link
Member Author

I get the same display of the buttons for Jesse - for the smallest screens I don't have the problem, but when I open the sidebar then the issue occurs for me

@sahilvunnam
Copy link
Member Author

I'll try to fix the issue with the sidebar opening

@sahilvunnam
Copy link
Member Author

Just fixed the issue, please check

@Gavinp14
Copy link
Member

Gavinp14 commented Nov 1, 2024

Do you want it to look like this with the sidebar opened or would it make more sense for all the buttons to be aligned properly?
sidebarq

Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Everthing looks good, i was just wondering if its better to have everything centered again in the calendar, since its kind of awkward if you have it in left aligned, but thats my opinion though

Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting weird formatting when the sidebar is open on small screens.
image

@sahilvunnam
Copy link
Member Author

@jessewashburn I get this for super small screens

Image 11-7-24 at 6 41 AM

@Mutugiii
Copy link
Member

Include changes from #7448

image

image

@dogi dogi changed the title calendar toolbar: smoother view for super small screens (fixes #6796) community: smoother calendar (fixes #6796) Nov 14, 2024
@dogi dogi merged commit d9c3f55 into master Nov 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar: Add the space between buttons
6 participants