Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: smoother edit title (fixes #7728) #7731

Merged

Conversation

jessewashburn
Copy link
Member

Courses/resources now have a dynamic label based on the action (Add or Edit).

Fixes #7728

image

image

image

image

dynamic resources add/edit
dynamic resources add/edit
dynamic courses add/edit
Dynamic courses add/edit
Copy link
Member

@Mutugiii Mutugiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some parts of the code we find checks for pageType === 'Add New' or pageType === 'update'

e,g courses-add.component.ts line 202 & 234

Made pagetype references more consistent
Made pagetype references more consistent
@jessewashburn
Copy link
Member Author

In some parts of the code we find checks for pageType === 'Add New' or pageType === 'update'

e,g courses-add.component.ts line 202 & 234

Ah, I see. This has been corrected now.

@dogi dogi changed the title Courses/Library: dynamic label for adding and editing resources (Fixes #7728) resources: smoother edit title (fixes #7728) Nov 15, 2024
@dogi dogi merged commit 7dc950d into master Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

courses/library: Add Course/Resource label should be dynamic
5 participants